path: root/t
diff options
authorJeff King <>2020-05-03 09:11:57 (GMT)
committerJunio C Hamano <>2020-05-04 20:41:20 (GMT)
commit76f9e569adb540a1ca1a590c512d57fce4eea878 (patch)
treef7014c05f22c2ae7870a694de613219ed32a8d75 /t
parent041bc65923e13313ca1b77681c3b2950b5e0a163 (diff)
ref-filter: apply --ignore-case to all sorting keys
All of the ref-filter users (for-each-ref, branch, and tag) take an --ignore-case option which makes filtering and sorting case-insensitive. However, this option was applied only to the first element of the ref_sorting list. So: git for-each-ref --ignore-case --sort=refname would do what you expect, but: git for-each-ref --ignore-case --sort=refname --sort=taggername would sort the primary key (taggername) case-insensitively, but sort the refname case-sensitively. We have two options here: - teach callers to set ignore_case on the whole list - replace the ref_sorting list with a struct that contains both the list of sorting keys, as well as options that apply to _all_ keys I went with the first one here, as it gives more flexibility if we later want to let the users set the flag per-key (presumably through some special syntax when defining the key; for now it's all or nothing through --ignore-case). The new test covers this by sorting on both tagger and subject case-insensitively, which should compare "a" and "A" identically, but still sort them before "b" and "B". We'll break ties by sorting on the refname to give ourselves a stable output (this is actually supposed to be done automatically, but there's another bug which will be fixed in the next commit). Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 't')
1 files changed, 40 insertions, 0 deletions
diff --git a/t/ b/t/
index 97bfbee..b347bba 100755
--- a/t/
+++ b/t/
@@ -828,4 +828,44 @@ test_expect_success 'for-each-ref --ignore-case ignores case' '
test_cmp expect actual
+test_expect_success 'for-each-ref --ignore-case works on multiple sort keys' '
+ # name refs numerically to avoid case-insensitive filesystem conflicts
+ nr=0 &&
+ for email in a A b B
+ do
+ for subject in a A b B
+ do
+ git tag -m "tag $subject" icase-$(printf %02d $nr) &&
+ nr=$((nr+1))||
+ return 1
+ done
+ done &&
+ git for-each-ref --ignore-case \
+ --format="%(taggeremail) %(subject) %(refname)" \
+ --sort=refname \
+ --sort=subject \
+ --sort=taggeremail \
+ refs/tags/icase-* >actual &&
+ cat >expect <<-\EOF &&
+ <> tag a refs/tags/icase-00
+ <> tag A refs/tags/icase-01
+ <> tag a refs/tags/icase-04
+ <> tag A refs/tags/icase-05
+ <> tag b refs/tags/icase-02
+ <> tag B refs/tags/icase-03
+ <> tag b refs/tags/icase-06
+ <> tag B refs/tags/icase-07
+ <> tag a refs/tags/icase-08
+ <> tag A refs/tags/icase-09
+ <> tag a refs/tags/icase-12
+ <> tag A refs/tags/icase-13
+ <> tag b refs/tags/icase-10
+ <> tag B refs/tags/icase-11
+ <> tag b refs/tags/icase-14
+ <> tag B refs/tags/icase-15
+ test_cmp expect actual