diff options
| author | Arnout Engelen <arnouten@bzzt.net> | 2010-12-18 21:28:00 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2010-12-22 03:51:17 (GMT) |
| commit | 6cf6bb3e47ac2f667fa0b27a4222e903ff6fb77c (patch) | |
| tree | 6f85fb8abadf0e819712c74361b52852858d543a /t | |
| parent | 853563d7344ee532aa56f8a9aabcfdfb5c4fe2c3 (diff) | |
| download | git-6cf6bb3e47ac2f667fa0b27a4222e903ff6fb77c.zip git-6cf6bb3e47ac2f667fa0b27a4222e903ff6fb77c.tar.gz git-6cf6bb3e47ac2f667fa0b27a4222e903ff6fb77c.tar.bz2 | |
Improve error messages when temporary file creation fails
Before, when creating a temporary file failed, a generic 'Unable to create
temporary file' message was printed. In some cases this could lead to
confusion as to which directory should be checked for correct permissions etc.
This patch adds the template for the temporary filename to the error message,
converting it to an absolute path if needed. A test verifies that the template
is indeed printed when pointing to a nonexistent or unwritable directory.
A copy of the original template is made in case mkstemp clears the template.
Signed-off-by: Arnout Engelen <arnouten@bzzt.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
| -rwxr-xr-x | t/t0070-fundamental.sh | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/t/t0070-fundamental.sh b/t/t0070-fundamental.sh index 680d7d6..9bee8bf 100755 --- a/t/t0070-fundamental.sh +++ b/t/t0070-fundamental.sh @@ -12,4 +12,17 @@ test_expect_success 'character classes (isspace, isalpha etc.)' ' test-ctype ' +test_expect_success 'mktemp to nonexistent directory prints filename' ' + test_must_fail test-mktemp doesnotexist/testXXXXXX 2>err && + grep "doesnotexist/test" err +' + +test_expect_success POSIXPERM 'mktemp to unwritable directory prints filename' ' + mkdir cannotwrite && + chmod -w cannotwrite && + test_when_finished "chmod +w cannotwrite" && + test_must_fail test-mktemp cannotwrite/testXXXXXX 2>err && + grep "cannotwrite/test" err +' + test_done |