path: root/t
diff options
authorTaylor Blau <>2020-04-29 17:36:46 (GMT)
committerJunio C Hamano <>2020-04-29 19:35:30 (GMT)
commit45a4365cb610adce1c37c099da7d18619725ce4f (patch)
tree9e85404e6e5dfe3c663c856a3fb06453e6b2fa45 /t
parentf4d62847a431af965b8a6895b92f4372042457b0 (diff)
commit-graph.c: make 'commit-graph-chain's read-only
In a previous commit, we made incremental graph layers read-only by using 'git_mkstemp_mode' with permissions '0444'. There is no reason that 'commit-graph-chain's should be modifiable by the user, since they are generated at a temporary location and then atomically renamed into place. To ensure that these files are read-only, too, use 'hold_lock_file_for_update_mode' with the same read-only permission bits, and let the umask and 'adjust_shared_perm' take care of the rest. Signed-off-by: Taylor Blau <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 't')
1 files changed, 2 insertions, 0 deletions
diff --git a/t/ b/t/
index 699c23d..cff5a41 100755
--- a/t/
+++ b/t/
@@ -366,6 +366,8 @@ do
test_line_count = 1 graph-files &&
echo "$modebits" >expect &&
test_modebits $graphdir/graph-*.graph >actual &&
+ test_cmp expect actual &&
+ test_modebits $graphdir/commit-graph-chain >actual &&
test_cmp expect actual
done <<\EOF