path: root/t
diff options
authorbrian m. carlson <>2015-06-21 23:14:40 (GMT)
committerJunio C Hamano <>2015-06-22 21:20:46 (GMT)
commit434060ec6d9bf50f095db901da3fb9b557e11df1 (patch)
tree7a7dc99fb6b8e1e5eaa566ec4eb5e29ff807e8f2 /t
parent8e98e5f27aba812c0f095b7e546871e14a4139f6 (diff)
gpg: centralize signature check
verify-commit and verify-tag both share a central codepath for verifying commits: check_signature. However, verify-tag exited successfully for untrusted signature, while verify-commit exited unsuccessfully. Centralize this signature check and make verify-commit adopt the older verify-tag behavior. This behavior is more logical anyway, as the signature is in fact valid, whether or not there's a path of trust to the author. Signed-off-by: brian m. carlson <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 't')
1 files changed, 1 insertions, 1 deletions
diff --git a/t/ b/t/
index 4fc376e..796138f 100755
--- a/t/
+++ b/t/
@@ -81,7 +81,7 @@ test_expect_success GPG 'verify and show signatures' '
-test_expect_failure GPG 'verify-commit exits success on untrusted signature' '
+test_expect_success GPG 'verify-commit exits success on untrusted signature' '
git verify-commit eighth-signed-alt 2>actual &&
grep "Good signature from" actual &&
! grep "BAD signature from" actual &&