path: root/t/
diff options
authorDenton Liu <>2020-04-20 08:54:45 (GMT)
committerJunio C Hamano <>2020-04-20 20:30:55 (GMT)
commit546f352638fd4fd7e517e8c6e74e229825e9afab (patch)
tree8cac81a81595ffb052de04801a1b347a0d2ad9fc /t/
parentbf1218106835fb06f8862c6727dd4453e9ea5fd9 (diff)
t9819: don't use test_must_fail with p4
We were using `test_must_fail p4` to test that the p4 command failed as expected. However, test_must_fail() is used to ensure that commands fail in an expected way, not due to something like a segv. Since we are not in the business of verifying the sanity of the external world, replace `test_must_fail p4` with `! p4` and assume that the `p4` command does not die unexpectedly. Signed-off-by: Denton Liu <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 't/')
1 files changed, 1 insertions, 1 deletions
diff --git a/t/ b/t/
index 600ce1e..b4d93f0 100755
--- a/t/
+++ b/t/
@@ -30,7 +30,7 @@ test_expect_success 'Check p4 is in case-folding mode' '
cd "$cli" &&
>lc/FILE.TXT &&
p4 add lc/FILE.TXT &&
- test_must_fail p4 submit -d "Cannot add file differing only in case" lc/FILE.TXT
+ ! p4 submit -d "Cannot add file differing only in case" lc/FILE.TXT