diff options
| author | Elia Pinto <gitter.spiros@gmail.com> | 2016-01-12 10:45:18 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2016-01-12 19:47:29 (GMT) |
| commit | 1d9e86f80d2ede6829c57ef4b22e4dd8b162cc7e (patch) | |
| tree | 17d94e8f47054f84c98c9a5c0840eec3924c7185 /t/t9118-git-svn-funky-branch-names.sh | |
| parent | 78ba28d84b5be8cbb1d5d5e7d65b5522739ad5ce (diff) | |
| download | git-1d9e86f80d2ede6829c57ef4b22e4dd8b162cc7e.zip git-1d9e86f80d2ede6829c57ef4b22e4dd8b162cc7e.tar.gz git-1d9e86f80d2ede6829c57ef4b22e4dd8b162cc7e.tar.bz2 | |
t9118-git-svn-funky-branch-names.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}"
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t9118-git-svn-funky-branch-names.sh')
| -rwxr-xr-x | t/t9118-git-svn-funky-branch-names.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t9118-git-svn-funky-branch-names.sh b/t/t9118-git-svn-funky-branch-names.sh index ed4d136..a221915 100755 --- a/t/t9118-git-svn-funky-branch-names.sh +++ b/t/t9118-git-svn-funky-branch-names.sh @@ -35,7 +35,7 @@ test_expect_success 'setup svnrepo' ' # SVN 1.7 will truncate "not-a%40{0]" to just "not-a". # Look at what SVN wound up naming the branch and use that. # Be sure to escape the @ if it shows up. -non_reflog=`svn_cmd ls "$svnrepo/pr ject/branches" | grep not-a | sed 's/\///' | sed 's/@/%40/'` +non_reflog=$(svn_cmd ls "$svnrepo/pr ject/branches" | grep not-a | sed 's/\///' | sed 's/@/%40/') test_expect_success 'test clone with funky branch names' ' git svn clone -s "$svnrepo/pr ject" project && |