path: root/t/
diff options
authorJeff King <>2018-08-23 00:48:21 (GMT)
committerJunio C Hamano <>2018-08-23 17:08:51 (GMT)
commitc188668e387509565237a865a1c63e890f6bbcd7 (patch)
treede41433adf73551f80cb62f49061816644a12ce8 /t/
parent00a21f5cbda35eb5d355b453849b625eeca7eac4 (diff)
interpret-trailers: tighten check for "---" patch boundary
The interpret-trailers command accepts not only raw commit messages, but it also can manipulate trailers in format-patch output. That means it must find the "---" boundary separating the commit message from the patch. However, it does so by looking for any line starting with "---", regardless of whether there is further content. This is overly lax compared to the parsing done in mailinfo.c's patchbreak(), and may cause false positives (e.g., t/perf output tables uses dashes; if you cut and paste them into your commit message, it fools the parser). We could try to reuse patchbreak() here, but it actually has several heuristics that are not of interest to us (e.g., matching "diff -" without a three-dash separator or even a CVS "Index:" line). We're not interested in taking in whatever random cruft people may send, but rather handling git-formatted patches. Note that the existing documentation was written in a loose way, so technically we are changing the behavior from what it said. But this should implement the original intent in a more accurate way. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 't/')
1 files changed, 22 insertions, 0 deletions
diff --git a/t/ b/t/
index 164719d..e13b40b 100755
--- a/t/
+++ b/t/
@@ -1417,4 +1417,26 @@ test_expect_success 'unfold' '
test_cmp expected actual
+test_expect_success 'handling of --- lines in input' '
+ echo "real-trailer: just right" >expected &&
+ git interpret-trailers --parse >actual <<-\EOF &&
+ subject
+ body
+ not-a-trailer: too soon
+ ------ this is just a line in the commit message with a bunch of
+ ------ dashes; it does not have any syntactic meaning.
+ real-trailer: just right
+ ---
+ below the dashed line may be a patch, etc.
+ not-a-trailer: too late
+ test_cmp expected actual