diff options
| author | Phillip Wood <phillip.wood@dunelm.org.uk> | 2019-08-19 09:18:21 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2019-08-19 22:27:09 (GMT) |
| commit | 450efe2d53b67f67b5efc11172ed0706cbd4f776 (patch) | |
| tree | 1ccf49fd1b35684d7baa0bbcc7bf1a0d322a4dd2 /t/t7505/expected-rebase-i | |
| parent | 4d8ec15c66f32e29e4dfcdf64d0826c425d8ad7d (diff) | |
| download | git-450efe2d53b67f67b5efc11172ed0706cbd4f776.zip git-450efe2d53b67f67b5efc11172ed0706cbd4f776.tar.gz git-450efe2d53b67f67b5efc11172ed0706cbd4f776.tar.bz2 | |
rebase -i: always update HEAD before rewording
If the user runs git log while rewording a commit it is confusing if
sometimes we're amending the commit that's being reworded and at other
times we're creating a new commit depending on whether we could
fast-forward or not[1]. Fix this inconsistency by always committing the
picked commit and then running 'git commit --amend' to do the reword.
The first commit is performed by the sequencer without forking git
commit and does not impact on the speed of rebase. In a test rewording
100 commits with
GIT_EDITOR=true GIT_SEQUENCE_EDITOR='sed -i s/pick/reword/' \
../bin-wrappers/git rebase -i --root
and taking the best of three runs the current master took
957ms and with this patch it took 961ms.
This change fixes rewording the new root commit when rearranging commits
with --root.
Note that the new code no longer updates CHERRY_PICK_HEAD after creating
a root commit - I'm not sure why the old code was that creating that ref
after a successful commit, everywhere else it is removed after a
successful commit.
[1] https://public-inbox.org/git/xmqqlfvu4be3.fsf@gitster-ct.c.googlers.com/T/#m133009cb91cf0917bcf667300f061178be56680a
Reported-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t7505/expected-rebase-i')
| -rw-r--r-- | t/t7505/expected-rebase-i | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/t/t7505/expected-rebase-i b/t/t7505/expected-rebase-i index c514bdb..93bada5 100644 --- a/t/t7505/expected-rebase-i +++ b/t/t7505/expected-rebase-i @@ -7,7 +7,8 @@ message (no editor) [edit rebase-10] message [fixup rebase-9] message (no editor) [fixup rebase-8] message (no editor) [squash rebase-7] -message [reword rebase-6] +HEAD [reword rebase-6] +message (no editor) [reword rebase-6] message [squash rebase-5] message (no editor) [fixup rebase-4] message (no editor) [pick rebase-3] |