path: root/t/
diff options
authorJeff King <>2011-12-12 14:25:51 (GMT)
committerJunio C Hamano <>2011-12-12 17:09:35 (GMT)
commita9bfbc5b698103b1553e1023c4f77001cc861e79 (patch)
treec7357e4a4a70b5fc712770da1461717d4c395d06 /t/
parent26db0f2e3afc043e184a5e0ce5eb7c53aeb1f644 (diff)
compat/snprintf: don't look at va_list twice
If you define SNPRINTF_RETURNS_BOGUS, we use a special git_vsnprintf wrapper assumes that vsnprintf returns "-1" instead of the number of characters that you would need to store the result. To do this, it invokes vsnprintf multiple times, growing a heap buffer until we have enough space to hold the result. However, this means we evaluate the va_list parameter multiple times, which is generally a bad thing (it may be modified by calls to vsnprintf, yielding undefined behavior). Instead, we must va_copy it and hand the copy to vsnprintf, so we always have a pristine va_list. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 't/')
0 files changed, 0 insertions, 0 deletions