path: root/t/
diff options
authorEric Sunshine <>2021-12-09 05:11:07 (GMT)
committerJunio C Hamano <>2021-12-13 18:29:48 (GMT)
commitc576868eaff8cc4c7fb5cf8b787756b16fde268b (patch)
tree4b109bff782f639dfeb0ff6e897edd48a19fa557 /t/
parent74d2f5695dab4454097b2d1693f7206e8328724a (diff)
tests: fix broken &&-chains in `$(...)` command substitutions
The top-level &&-chain checker built into t/ causes tests to magically exit with code 117 if the &&-chain is broken. However, it has the shortcoming that the magic does not work within `{...}` groups, `(...)` subshells, `$(...)` substitutions, or within bodies of compound statements, such as `if`, `for`, `while`, `case`, etc. `chainlint.sed` partly fills in the gap by catching broken &&-chains in `(...)` subshells, but bugs can still lurk behind broken &&-chains in the other cases. Fix broken &&-chains in `$(...)` command substitutions in order to reduce the number of possible lurking bugs. Signed-off-by: Eric Sunshine <> Reviewed-by: Elijah Newren <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 't/')
1 files changed, 1 insertions, 1 deletions
diff --git a/t/ b/t/
index 0335a9a..520f96d 100755
--- a/t/
+++ b/t/
@@ -137,7 +137,7 @@ test_expect_success 'setup deeper work tree' '
test_expect_success 'add a directory outside the work tree' '(
cd tester &&
- d1="$(cd .. ; pwd)" &&
+ d1="$(cd .. && pwd)" &&
test_must_fail git add "$d1"