path: root/t/
diff options
authorEric Sunshine <>2021-12-09 05:11:06 (GMT)
committerJunio C Hamano <>2021-12-13 18:29:48 (GMT)
commit74d2f5695dab4454097b2d1693f7206e8328724a (patch)
tree6d4a147a909ef45477fd1509e83530b7ed39bec9 /t/
parent0849541268a3aca9381591aed87b6864a203709b (diff)
tests: fix broken &&-chains in compound statements
The top-level &&-chain checker built into t/ causes tests to magically exit with code 117 if the &&-chain is broken. However, it has the shortcoming that the magic does not work within `{...}` groups, `(...)` subshells, `$(...)` substitutions, or within bodies of compound statements, such as `if`, `for`, `while`, `case`, etc. `chainlint.sed` partly fills in the gap by catching broken &&-chains in `(...)` subshells, but bugs can still lurk behind broken &&-chains in the other cases. Fix broken &&-chains in compound statements in order to reduce the number of possible lurking bugs. Signed-off-by: Eric Sunshine <> Reviewed-by: Elijah Newren <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 't/')
1 files changed, 1 insertions, 1 deletions
diff --git a/t/ b/t/
index c50d315..ed40801 100755
--- a/t/
+++ b/t/
@@ -47,7 +47,7 @@ test_rename() {
git commit -a -m change=$n &&
git checkout -b test$n HEAD^ &&
for i in $(count $n); do
- git rm $i
+ git rm $i &&
make_text $i initial changed >$i.moved
done &&
git add . &&