path: root/t/
diff options
authorBryan Donlan <>2008-05-04 05:37:59 (GMT)
committerJunio C Hamano <>2008-05-05 21:37:02 (GMT)
commitf69e836fab2b634281d92a0d304de4d768e479cc (patch)
treeebd3e28ff26f0077846085d5c86970cc5ee05759 /t/
parent0e46e704626af5189c9c9ff2c0f348d2205c10f3 (diff)
Fix tests breaking when checkout path contains shell metacharacters
This fixes the remainder of the issues where the test script itself is at fault for failing when the git checkout path contains whitespace or other shell metacharacters. The majority of git svn tests used the idiom test_expect_success "title" "test script using $svnrepo" These were changed to have the test script in single-quotes: test_expect_success "title" 'test script using "$svnrepo"' which unfortunately makes the patch appear larger than it really is. One consequence of this change is that in the verbose test output the value of $svnrepo (and in some cases other variables, too) is no longer expanded, i.e. previously we saw * expecting success: test script using /path/to/git/t/trash/svnrepo but now it is: * expecting success: test script using "$svnrepo" Signed-off-by: Bryan Donlan <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 't/')
1 files changed, 1 insertions, 1 deletions
diff --git a/t/ b/t/
index b6a5486..e5619a9 100755
--- a/t/
+++ b/t/
@@ -51,7 +51,7 @@ diff expected current'
cd "$base_dir"
test_expect_success 'cloning with reference (no -l -s)' \
-'git clone --reference B file://`pwd`/A D'
+'git clone --reference B "file://$(pwd)/A" D'
cd "$base_dir"