path: root/t/
diff options
authorSZEDER Gábor <>2018-02-08 15:56:48 (GMT)
committerJunio C Hamano <>2018-02-08 18:54:27 (GMT)
commit8cdef01c4282e6006b785a0222589ccd2b65a187 (patch)
treead20e4d48303b1148ece68c6aaf1121bfb4631cb /t/
parent8279ed033f703d4115bee620dccd32a9ec94d9aa (diff)
t5541: add 'test_i18ngrep's missing filename parameter
The test 'push --no-progress silences progress but not status' runs 'test_i18ngrep' without specifying a filename parameter. This has remained unnoticed since its introduction in e304aeba2 (t5541: test more combinations of --progress, 2012-05-01), because that 'test_i18ngrep' is supposed to check that the given pattern is not present in its input, and of course it won't find that pattern if its input is empty (as it comes from /dev/null). This also means that this test could miss a potential breakage of 'git push --no-progress'. Signed-off-by: SZEDER Gábor <> Reviewed-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 't/')
1 files changed, 1 insertions, 1 deletions
diff --git a/t/ b/t/
index d38bf32..21340e8 100755
--- a/t/
+++ b/t/
@@ -234,7 +234,7 @@ test_expect_success TTY 'push --no-progress silences progress but not status' '
test_commit no-progress &&
test_terminal git push --no-progress >output 2>&1 &&
test_i18ngrep "^To http" output &&
- test_i18ngrep ! "^Writing objects"
+ test_i18ngrep ! "^Writing objects" output
test_expect_success 'push --progress shows progress to non-tty' '