path: root/t/
diff options
authorBrandon Williams <>2016-11-17 18:46:04 (GMT)
committerJunio C Hamano <>2016-11-23 16:39:14 (GMT)
commit0301c821c5cd124733accfbff0ddbf7f0b0ee9fb (patch)
treeb41edb26a5a5e4b91b24124bec9c0df067e2be19 /t/
parent1aa73658405ad423127b3c14ac13e46f9ad0163a (diff)
push: fix --dry-run to not push submodules
Teach push to respect the --dry-run option when configured to recursively push submodules 'on-demand'. This is done by passing the --dry-run flag to the child process which performs a push for a submodules when performing a dry-run. In order to preserve good user experience, the additional check for unpushed submodules is skipped during a dry-run when --recurse-submodules=on-demand. The check is skipped because the submodule pushes were performed as dry-runs and this check would always fail as the submodules would still need to be pushed. Signed-off-by: Brandon Williams <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 't/')
1 files changed, 1 insertions, 1 deletions
diff --git a/t/ b/t/
index 7840032..1524ff5 100755
--- a/t/
+++ b/t/
@@ -431,7 +431,7 @@ test_expect_success 'push unpushable submodule recursively fails' '
test_cmp expected actual
-test_expect_failure 'push --dry-run does not recursively update submodules' '
+test_expect_success 'push --dry-run does not recursively update submodules' '
cd work/gar/bage &&
git checkout master &&