diff options
| author | Pranit Bauva <pranit.bauva@gmail.com> | 2017-01-03 19:57:07 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2017-01-07 21:20:01 (GMT) |
| commit | c7cf956618c4af9f3151a90d7552b05767e6444f (patch) | |
| tree | ea074b87fcb872c13df8b0b5d2c3d2b12c5a89d6 /t/t5516-fetch-push.sh | |
| parent | a274e0a036ea886a31f8b216564ab1b4a3142f6c (diff) | |
| download | git-c7cf956618c4af9f3151a90d7552b05767e6444f.zip git-c7cf956618c4af9f3151a90d7552b05767e6444f.tar.gz git-c7cf956618c4af9f3151a90d7552b05767e6444f.tar.bz2 | |
don't use test_must_fail with grep
test_must_fail should only be used for testing git commands. To test the
failure of other commands use `!`.
Reported-by: Stefan Beller <sbeller@google.com>
Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5516-fetch-push.sh')
| -rwxr-xr-x | t/t5516-fetch-push.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh index 26b2caf..0fc5a7c 100755 --- a/t/t5516-fetch-push.sh +++ b/t/t5516-fetch-push.sh @@ -1004,7 +1004,7 @@ test_expect_success 'push --porcelain' ' test_expect_success 'push --porcelain bad url' ' mk_empty testrepo && test_must_fail git push >.git/bar --porcelain asdfasdfasd refs/heads/master:refs/remotes/origin/master && - test_must_fail grep -q Done .git/bar + ! grep -q Done .git/bar ' test_expect_success 'push --porcelain rejected' ' |