diff options
author | Eric Sunshine <sunshine@sunshineco.com> | 2021-12-09 05:11:14 (GMT) |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2021-12-13 18:29:48 (GMT) |
commit | d0fd993137cf41be66b54628f124b6651eea0bd2 (patch) | |
tree | 5cf3d6ab76f75dabaac0ddff6cdca03dcaaf289d /t/t5317-pack-objects-filter-objects.sh | |
parent | cbe1d9d630e529d3dd240eacf3d1c9799fef702b (diff) | |
download | git-d0fd993137cf41be66b54628f124b6651eea0bd2.zip git-d0fd993137cf41be66b54628f124b6651eea0bd2.tar.gz git-d0fd993137cf41be66b54628f124b6651eea0bd2.tar.bz2 |
t5000-t5999: detect and signal failure within loop
Failures within `for` and `while` loops can go unnoticed if not detected
and signaled manually since the loop itself does not abort when a
contained command fails, nor will a failure necessarily be detected when
the loop finishes since the loop returns the exit code of the last
command it ran on the final iteration, which may not be the command
which failed. Therefore, detect and signal failures manually within
loops using the idiom `|| return 1` (or `|| exit 1` within subshells).
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Reviewed-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5317-pack-objects-filter-objects.sh')
-rwxr-xr-x | t/t5317-pack-objects-filter-objects.sh | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/t/t5317-pack-objects-filter-objects.sh b/t/t5317-pack-objects-filter-objects.sh index 8fb6aca..33b740ce 100755 --- a/t/t5317-pack-objects-filter-objects.sh +++ b/t/t5317-pack-objects-filter-objects.sh @@ -18,7 +18,7 @@ test_expect_success 'setup r1' ' do echo "This is file: $n" > r1/file.$n && git -C r1 add file.$n && - git -C r1 commit -m "$n" + git -C r1 commit -m "$n" || return 1 done ' @@ -118,7 +118,7 @@ test_expect_success 'setup r2' ' do printf "%"$n"s" X > r2/large.$n && git -C r2 add large.$n && - git -C r2 commit -m "$n" + git -C r2 commit -m "$n" || return 1 done ' @@ -281,7 +281,7 @@ test_expect_success 'setup r3' ' echo "This is file: $n" > r3/$n && git -C r3 add $n && echo "This is file: dir1/$n" > r3/dir1/$n && - git -C r3 add dir1/$n + git -C r3 add dir1/$n || return 1 done && git -C r3 commit -m "sparse" && echo dir1/ >pattern1 && @@ -334,7 +334,7 @@ test_expect_success 'setup r4' ' echo "This is file: $n" > r4/$n && git -C r4 add $n && echo "This is file: dir1/$n" > r4/dir1/$n && - git -C r4 add dir1/$n + git -C r4 add dir1/$n || return 1 done && echo dir1/ >r4/pattern && git -C r4 add pattern && @@ -409,7 +409,7 @@ test_expect_success 'setup r1 - delete loose blobs' ' for id in `cat expected | sed "s|..|&/|"` do - rm r1/.git/objects/$id + rm r1/.git/objects/$id || return 1 done ' |