summaryrefslogtreecommitdiff
path: root/t/t5310-pack-bitmaps.sh
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2018-09-01 07:50:57 (GMT)
committerJunio C Hamano <gitster@pobox.com>2018-09-04 15:40:14 (GMT)
commit199c86be1623ab5053b4ed0ce6ed2ae974e3e859 (patch)
tree5ad5090b018fba30f1eecd290c4c3df993aa1093 /t/t5310-pack-bitmaps.sh
parent715d0c50e1ba479290d9fcb34119d8f9a09bfed3 (diff)
downloadgit-199c86be1623ab5053b4ed0ce6ed2ae974e3e859.zip
git-199c86be1623ab5053b4ed0ce6ed2ae974e3e859.tar.gz
git-199c86be1623ab5053b4ed0ce6ed2ae974e3e859.tar.bz2
pack-bitmap: drop "loaded" flag
In the early days of the bitmap code, there was a single static bitmap_index struct that was used behind the scenes, and any bitmap-related functions could lazily check bitmap_git.loaded to see if they needed to read the on-disk data. But since 3ae5fa0768 (pack-bitmap: remove bitmap_git global variable, 2018-06-07), the caller is responsible for the lifetime of the bitmap_index struct, and we return it from prepare_bitmap_git() and prepare_bitmap_walk(), both of which load the on-disk data (or return NULL). So outside of these functions, it's not possible to have a bitmap_index for which the loaded flag is not true. Nor is it possible to accidentally pass an already-loaded bitmap_index to the loading function (which is static-local to the file). We can drop this unnecessary and confusing flag. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5310-pack-bitmaps.sh')
0 files changed, 0 insertions, 0 deletions