summaryrefslogtreecommitdiff
path: root/t/t5305-include-tag.sh
diff options
context:
space:
mode:
authorElia Pinto <gitter.spiros@gmail.com>2015-12-23 13:45:51 (GMT)
committerJunio C Hamano <gitster@pobox.com>2015-12-28 21:37:03 (GMT)
commit0469cb96e354e71d6f07d4cbfe58cf7d868d6b4a (patch)
treee1836be457f03def1df978d9c5ea3bac05737970 /t/t5305-include-tag.sh
parent213ea1161cf68963807ec7b254c63ddfc9c96838 (diff)
downloadgit-0469cb96e354e71d6f07d4cbfe58cf7d868d6b4a.zip
git-0469cb96e354e71d6f07d4cbfe58cf7d868d6b4a.tar.gz
git-0469cb96e354e71d6f07d4cbfe58cf7d868d6b4a.tar.bz2
t/t5305-include-tag.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5305-include-tag.sh')
-rwxr-xr-xt/t5305-include-tag.sh8
1 files changed, 4 insertions, 4 deletions
diff --git a/t/t5305-include-tag.sh b/t/t5305-include-tag.sh
index 21517c7..f314ad5 100755
--- a/t/t5305-include-tag.sh
+++ b/t/t5305-include-tag.sh
@@ -3,20 +3,20 @@
test_description='git pack-object --include-tag'
. ./test-lib.sh
-TRASH=`pwd`
+TRASH=$(pwd)
test_expect_success setup '
echo c >d &&
git update-index --add d &&
- tree=`git write-tree` &&
- commit=`git commit-tree $tree </dev/null` &&
+ tree=$(git write-tree) &&
+ commit=$(git commit-tree $tree </dev/null) &&
echo "object $commit" >sig &&
echo "type commit" >>sig &&
echo "tag mytag" >>sig &&
echo "tagger $(git var GIT_COMMITTER_IDENT)" >>sig &&
echo >>sig &&
echo "our test tag" >>sig &&
- tag=`git mktag <sig` &&
+ tag=$(git mktag <sig) &&
rm d sig &&
git update-ref refs/tags/mytag $tag && {
echo $tree &&