diff options
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2017-05-20 21:42:09 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2017-05-20 23:25:37 (GMT) |
| commit | 9001c1920c9b812efc671bdc0c313d0a3418d8ee (patch) | |
| tree | 4e627b666edb0746dc08168d6210db6b2a0eb0b8 /t/t4202-log.sh | |
| parent | 9e3cbc59d5ec9d1b53c0c2e8c81fa2f3adca5696 (diff) | |
| download | git-9001c1920c9b812efc671bdc0c313d0a3418d8ee.zip git-9001c1920c9b812efc671bdc0c313d0a3418d8ee.tar.gz git-9001c1920c9b812efc671bdc0c313d0a3418d8ee.tar.bz2 | |
grep: add a test asserting that --perl-regexp dies when !PCRE
Add a test asserting that when --perl-regexp (and -P for grep) is
given to git-grep & git-log that we die with an error.
In developing the PCRE v2 series I introduced a regression where -P
would (through control-flow fall-through) become synonymous with basic
POSIX matching. I.e. 'git grep -P '[\d]' would match "d" instead of
digits.
The entire test suite would still pass with this serious regression,
since everything that tested for --perl-regexp would be guarded by the
PCRE prerequisite, fix that blind-spot by adding tests under !PCRE
asserting that git must die when given --perl-regexp or -P.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t4202-log.sh')
| -rwxr-xr-x | t/t4202-log.sh | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/t/t4202-log.sh b/t/t4202-log.sh index 547f4c1..dbed3ef 100755 --- a/t/t4202-log.sh +++ b/t/t4202-log.sh @@ -418,7 +418,9 @@ test_expect_success 'log with various grep.patternType configurations & command- git log --pretty=tformat:%s --perl-regexp \ --grep="[\d]\|" >actual.perl.long-arg && test_cmp expect.perl actual.perl.long-arg - + else + test_must_fail git log --perl-regexp \ + --grep="[\d]\|" fi && test_cmp expect.fixed actual.fixed.long-arg && test_cmp expect.basic actual.basic.long-arg && |