summaryrefslogtreecommitdiff
path: root/t/t4202-log.sh
diff options
context:
space:
mode:
authorMatthew DeVore <matvore@google.com>2018-10-23 01:13:42 (GMT)
committerJunio C Hamano <gitster@pobox.com>2018-10-23 04:52:57 (GMT)
commit669b1d2aaec73ba762bf566078308075886ca208 (patch)
tree221c7ff149683106450a6ba51e2b613c0bffae27 /t/t4202-log.sh
parent368a89124c3ad859631452f7b012d0ad939375f3 (diff)
downloadgit-669b1d2aaec73ba762bf566078308075886ca208.zip
git-669b1d2aaec73ba762bf566078308075886ca208.tar.gz
git-669b1d2aaec73ba762bf566078308075886ca208.tar.bz2
exclude-promisor-objects: declare when option is allowed
The --exclude-promisor-objects option causes some funny behavior in at least two commands: log and blame. It causes a BUG crash: $ git log --exclude-promisor-objects BUG: revision.c:2143: exclude_promisor_objects can only be used when fetch_if_missing is 0 Aborted [134] Fix this such that the option is treated like any other unknown option. The commands that must support it are limited, so declare in those commands that the flag is supported. In particular: pack-objects prune rev-list The commands were found by searching for logic which parses --exclude-promisor-objects outside of revision.c. Extra logic outside of revision.c is needed because fetch_if_missing must be turned on before revision.c sees the option or it will BUG-crash. The above list is supported by the fact that no other command is introspectively invoked by another command passing --exclude-promisor-object. Signed-off-by: Matthew DeVore <matvore@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t4202-log.sh')
-rwxr-xr-xt/t4202-log.sh4
1 files changed, 4 insertions, 0 deletions
diff --git a/t/t4202-log.sh b/t/t4202-log.sh
index 25b1f8c..61610ce 100755
--- a/t/t4202-log.sh
+++ b/t/t4202-log.sh
@@ -1668,4 +1668,8 @@ test_expect_success 'log --source paints symmetric ranges' '
test_cmp expect actual
'
+test_expect_success '--exclude-promisor-objects does not BUG-crash' '
+ test_must_fail git log --exclude-promisor-objects source-a
+'
+
test_done