diff options
| author | Johannes Schindelin <johannes.schindelin@gmx.de> | 2016-09-21 18:24:14 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2016-09-21 20:56:15 (GMT) |
| commit | b7d36ffca02c23f545d6e098d78180e6e72dfd8d (patch) | |
| tree | ee20baae52d14d948c581efdbf30aff6fa2ee62e /t/t4062-diff-pickaxe.sh | |
| parent | 2f8952250a84313b74f96abb7b035874854cf202 (diff) | |
| download | git-b7d36ffca02c23f545d6e098d78180e6e72dfd8d.zip git-b7d36ffca02c23f545d6e098d78180e6e72dfd8d.tar.gz git-b7d36ffca02c23f545d6e098d78180e6e72dfd8d.tar.bz2 | |
regex: use regexec_buf()
The new regexec_buf() function operates on buffers with an explicitly
specified length, rather than NUL-terminated strings.
We need to use this function whenever the buffer we want to pass to
regexec(3) may have been mmap(2)ed (and is hence not NUL-terminated).
Note: the original motivation for this patch was to fix a bug where
`git diff -G <regex>` would crash. This patch converts more callers,
though, some of which allocated to construct NUL-terminated strings,
or worse, modified buffers to temporarily insert NULs while calling
regexec(3). By converting them to use regexec_buf(), the code has
become much cleaner.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t4062-diff-pickaxe.sh')
| -rwxr-xr-x | t/t4062-diff-pickaxe.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t4062-diff-pickaxe.sh b/t/t4062-diff-pickaxe.sh index 5929f2e..f0bf50b 100755 --- a/t/t4062-diff-pickaxe.sh +++ b/t/t4062-diff-pickaxe.sh @@ -14,7 +14,7 @@ test_expect_success setup ' test_tick && git commit -m "A 4k file" ' -test_expect_failure '-G matches' ' +test_expect_success '-G matches' ' git diff --name-only -G "^0{4096}$" HEAD^ >out && test 4096-zeroes.txt = "$(cat out)" ' |