summaryrefslogtreecommitdiff
path: root/t/t4018-diff-funcname.sh
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2020-01-16 18:34:23 (GMT)
committerJunio C Hamano <gitster@pobox.com>2020-01-16 22:46:28 (GMT)
commitfbce03d3291e80b76a75d37a44ecf4ab238e6837 (patch)
tree1d28417dfa4c0c3f19309772b2203efbed8ceb1d /t/t4018-diff-funcname.sh
parentb6d4d82bd5a49197d5d2f4f81c08da0d461cfcf1 (diff)
downloadgit-fbce03d3291e80b76a75d37a44ecf4ab238e6837.zip
git-fbce03d3291e80b76a75d37a44ecf4ab238e6837.tar.gz
git-fbce03d3291e80b76a75d37a44ecf4ab238e6837.tar.bz2
t4018: drop "debugging" cat from hunk-header tests
We run a series of hunk-header tests in a loop, and each one does this: test_when_finished 'cat actual' && # for debugging only This is pretty pointless. When the test succeeds, we waste time running a useless cat process. If you're debugging a failure with "-i", then we won't run the when-finished part at all. So it helps only if you're running with something like "--verbose-log". Since we expect the tests to succeed most of the time, a better way to do this would be a helper that checks the output and dumps "actual" only when it fails. But it's probably not even worth the effort, as anyone debugging a failure could just run with "-i" and investigate the "actual" file themselves. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t4018-diff-funcname.sh')
-rwxr-xr-xt/t4018-diff-funcname.sh1
1 files changed, 0 insertions, 1 deletions
diff --git a/t/t4018-diff-funcname.sh b/t/t4018-diff-funcname.sh
index 6f5ef00..803f717 100755
--- a/t/t4018-diff-funcname.sh
+++ b/t/t4018-diff-funcname.sh
@@ -105,7 +105,6 @@ do
result=success
fi
test_expect_$result "hunk header: $i" "
- test_when_finished 'cat actual' && # for debugging only
git diff -U1 $i >actual &&
grep '@@ .* @@.*RIGHT' actual
"