diff options
| author | Rubén Justo <rjusto@gmail.com> | 2024-03-30 14:08:59 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2024-03-31 00:55:01 (GMT) |
| commit | 1028db00f7bc47e2cecda8a4a9967fcc05fffb48 (patch) | |
| tree | fa63a7247bd667577b5a1c109eb4d50ad4d46a2a /t/t3700-add.sh | |
| parent | 9da49befd0ac6d014433c1ecb1a55570dbca9290 (diff) | |
| download | git-1028db00f7bc47e2cecda8a4a9967fcc05fffb48.zip git-1028db00f7bc47e2cecda8a4a9967fcc05fffb48.tar.gz git-1028db00f7bc47e2cecda8a4a9967fcc05fffb48.tar.bz2 | |
add: use advise_if_enabled for ADVICE_ADD_EMPTY_PATHSPEC
Since 93b0d86aaf (git-add: error out when given no arguments.,
2006-12-20) we display a message when no arguments are given to "git
add".
Part of that message was converted to advice in bf66db37f1 (add: use
advise function to display hints, 2020-01-07).
Following the same line of reasoning as in the previous commit, it is
sensible to use advise_if_enabled() here.
Therefore, use advise_if_enabled() in builtin/add.c to show the
ADVICE_ADD_EMPTY_PATHSPEC advice, and don't bother checking there the
visibility of the advice or displaying the instruction on how to disable
it.
Also add a test for these messages, in order to detect a possible
change in them.
Signed-off-by: Rubén Justo <rjusto@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t3700-add.sh')
| -rwxr-xr-x | t/t3700-add.sh | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/t/t3700-add.sh b/t/t3700-add.sh index 76c2c9e..681081e 100755 --- a/t/t3700-add.sh +++ b/t/t3700-add.sh @@ -28,6 +28,16 @@ test_expect_success 'Test of git add' ' touch foo && git add foo ' +test_expect_success 'Test with no pathspecs' ' + cat >expect <<-EOF && + Nothing specified, nothing added. + hint: Maybe you wanted to say ${SQ}git add .${SQ}? + hint: Disable this message with "git config advice.addEmptyPathspec false" + EOF + git add 2>actual && + test_cmp expect actual +' + test_expect_success 'Post-check that foo is in the index' ' git ls-files foo | grep foo ' |