path: root/t/
diff options
authorDavid Turner <>2016-02-24 22:58:51 (GMT)
committerMichael Haggerty <>2016-06-13 09:23:49 (GMT)
commit12fd3496d19c33c6401c5fdc7558944d46124a0f (patch)
tree541a62489823b571ff738ef7a1f3ff875acafdb7 /t/
parentd99aa884dff33d48d5aab8c9cf989a25c779fd70 (diff)
refs: don't dereference on rename
When renaming refs, don't dereference either the origin or the destination before renaming. The origin does not need to be dereferenced because it is presently forbidden to rename symbolic refs. Not dereferencing the destination fixes a bug where renaming on top of a broken symref would use the pointed-to ref name for the moved reflog. Add a test for the reflog bug. Signed-off-by: David Turner <> Signed-off-by: Junio C Hamano <> Signed-off-by: Michael Haggerty <>
Diffstat (limited to 't/')
1 files changed, 9 insertions, 0 deletions
diff --git a/t/ b/t/
index f3e3b6c..4281160 100755
--- a/t/
+++ b/t/
@@ -79,6 +79,15 @@ test_expect_success 'git branch -m dumps usage' '
test_i18ngrep "branch name required" err
+test_expect_success 'git branch -m m broken_symref should work' '
+ test_when_finished "git branch -D broken_symref" &&
+ git branch -l m &&
+ git symbolic-ref refs/heads/broken_symref refs/heads/i_am_broken &&
+ git branch -m m broken_symref &&
+ git reflog exists refs/heads/broken_symref &&
+ test_must_fail git reflog exists refs/heads/i_am_broken
test_expect_success 'git branch -m m m/m should work' '
git branch -l m &&
git branch -m m m/m &&