path: root/t/
diff options
authorJunio C Hamano <>2009-01-03 12:07:32 (GMT)
committerJunio C Hamano <>2009-01-03 21:34:19 (GMT)
commit3442ea4a75a3c76f65efac71b414584f765e5a99 (patch)
tree1ba10fed9fb2ef89b102e0462579133e6d851502 /t/
parent27c03aafdf29736f889c56777426066c74fa115d (diff)
git checkout: do not allow switching to a tree-ish that is not a commit
"git checkout -b newbranch $commit^{tree}" mistakenly created a new branch rooted at the current HEAD, because in that case, the two structure fields used to see if the command was invoked without any argument (hence it needs to default to checking out the HEAD) were populated incorrectly. Upon seeing a command line argument that we took as a rev, we should store that string in, even if that does not name a commit. This will correctly trigger the existing safety logic. Signed-off-by: Junio C Hamano <> Acked-by: Daniel Barkalow <>
Diffstat (limited to 't/')
1 files changed, 4 insertions, 0 deletions
diff --git a/t/ b/t/
index 764bb0a..15ebdc2 100755
--- a/t/
+++ b/t/
@@ -10,6 +10,10 @@ test_expect_success 'setup' '
git commit -m initial
+test_expect_success 'checkout should not start branch from a tree' '
+ test_must_fail git checkout -b newbranch master^{tree}
test_expect_success 'checkout master from invalid HEAD' '
echo 0000000000000000000000000000000000000000 >.git/HEAD &&
git checkout master --