path: root/t/perf/
diff options
authorMichał Kiedrowicz <>2012-08-03 22:21:04 (GMT)
committerJunio C Hamano <>2012-08-04 23:06:07 (GMT)
commitd17cf5f3a32f07bf8a6b8fb014abfa8e87fd7075 (patch)
treec42e0218f1631c17ea5d5947cfc4276ed61fe758 /t/perf/
parent0e4c8822e98e27c3c63125570c8bcbf0a8fd34da (diff)
tests: Introduce test_seq
Jeff King wrote: The seq command is GNU-ism, and is missing at least in older BSD releases and their derivatives, not to mention antique commercial Unixes. We already purged it in b3431bc (Don't use seq in tests, not everyone has it, 2007-05-02), but a few new instances have crept in. They went unnoticed because they are in scripts that are not run by default. Replace them with test_seq that is implemented with a Perl snippet (proposed by Jeff). This is better than inlining this snippet everywhere it's needed because it's easier to read and it's easier to change the implementation (e.g. to C) if we ever decide to remove Perl from the test suite. Note that test_seq is not a complete replacement for seq(1). It just has what we need now, in addition that it makes it possible for us to do something like "test_seq a m" if we wanted to in the future. There are also many places that do `for i in 1 2 3 ...` but I'm not sure if it's worth converting them to test_seq. That would introduce running more processes of Perl. Signed-off-by: Michał Kiedrowicz <> Acked-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 't/perf/')
1 files changed, 1 insertions, 1 deletions
diff --git a/t/perf/ b/t/perf/
index 5580c22..a1361e5 100644
--- a/t/perf/
+++ b/t/perf/
@@ -163,7 +163,7 @@ test_perf () {
echo "perf $test_count - $1:"
- for i in $(seq 1 $GIT_PERF_REPEAT_COUNT); do
+ for i in $(test_seq 1 $GIT_PERF_REPEAT_COUNT); do
say >&3 "running: $2"
if test_run_perf_ "$2"