summaryrefslogtreecommitdiff
path: root/t/perf/p5310-pack-bitmaps.sh
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2020-03-26 07:54:36 (GMT)
committerJunio C Hamano <gitster@pobox.com>2020-03-27 22:11:21 (GMT)
commit14d277879cfe4ef2f2d58f9a30458d2d84cee1df (patch)
treebd1eefc30d9aee3c20c2a8c57c7459490fb76490 /t/perf/p5310-pack-bitmaps.sh
parent274b9cc25322d9ee79aa8e6d4e86f0ffe5ced925 (diff)
downloadgit-14d277879cfe4ef2f2d58f9a30458d2d84cee1df.zip
git-14d277879cfe4ef2f2d58f9a30458d2d84cee1df.tar.gz
git-14d277879cfe4ef2f2d58f9a30458d2d84cee1df.tar.bz2
p5310: stop timing non-bitmap pack-to-disk
Commit 645c432d61 (pack-objects: use reachability bitmap index when generating non-stdout pack, 2016-09-10) added two timing tests for packing to an on-disk file, both with and without bitmaps. However, the non-bitmap one isn't interesting to have as part of p5310's regression suite. It _could_ be used as a baseline to show off the improvement in the bitmap case, but: - the point of the t/perf suite is to find performance regressions, and it won't help with that. We don't compare the numbers between two tests (which the perf suite has no idea are even related), and any change in its numbers would have nothing to do with bitmaps. - it did show off the improvement in the commit message of 645c432d61, but it wasn't even necessary there. The bitmap case already shows an improvement (because before the patch, it behaved the same as the non-bitmap case), and the perf suite is even able to show the difference between the before and after measurements. On top of that, it's one of the most expensive tests in the suite, clocking in around 60s for linux.git on my machine (as compared to 16s for the bitmapped version). And by default when using "./run", we'd run it three times! So let's just drop it. It's not useful and is adding minutes to perf runs. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/perf/p5310-pack-bitmaps.sh')
-rwxr-xr-xt/perf/p5310-pack-bitmaps.sh4
1 files changed, 0 insertions, 4 deletions
diff --git a/t/perf/p5310-pack-bitmaps.sh b/t/perf/p5310-pack-bitmaps.sh
index 7743f4f..80c53ed 100755
--- a/t/perf/p5310-pack-bitmaps.sh
+++ b/t/perf/p5310-pack-bitmaps.sh
@@ -31,10 +31,6 @@ test_perf 'simulated fetch' '
} | git pack-objects --revs --stdout >/dev/null
'
-test_perf 'pack to file' '
- git pack-objects --all pack1 </dev/null >/dev/null
-'
-
test_perf 'pack to file (bitmap)' '
git pack-objects --use-bitmap-index --all pack1b </dev/null >/dev/null
'