summaryrefslogtreecommitdiff
path: root/t/helper
diff options
context:
space:
mode:
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>2021-01-24 17:28:12 (GMT)
committerJunio C Hamano <gitster@pobox.com>2021-01-25 00:09:15 (GMT)
commita4fea08b6ebc2782891abdf6fd4bb9feeb21ff4d (patch)
treec02ae47f2d69e95d69adf8829d0c06baa64cf240 /t/helper
parent66e871b6647ffea61a77a0f82c7ef3415f1ee79c (diff)
downloadgit-a4fea08b6ebc2782891abdf6fd4bb9feeb21ff4d.zip
git-a4fea08b6ebc2782891abdf6fd4bb9feeb21ff4d.tar.gz
git-a4fea08b6ebc2782891abdf6fd4bb9feeb21ff4d.tar.bz2
grep/pcre2 tests: don't rely on invalid UTF-8 data test
As noted in [1] when I originally added this test in [2] the test was completely broken as it lacked a redirect[3]. I now think this whole thing is overly fragile. Let's only test if we have a segfault here. Before this the first test's "test_cmp" was pretty meaningless. We were only testing if PCREv2 was so broken that it would spew out something completely unrelated on stdout, which isn't very plausible. In the second test we're relying on PCREv2 forever holding to the current behavior of the PCRE_UTF8 flag, as opposed to learning some optimistic graceful fallback to PCRE2_MATCH_INVALID_UTF in the future. If that happens having this test broken under bisecting would suck. A follow-up commit will actually test this case in a meaningful way under the PCRE2_MATCH_INVALID_UTF flag. Let's run this one unconditionally, and just make sure we don't segfault. 1. e714b898c6 (t7812: expect failure for grep -i with invalid UTF-8 data, 2019-11-29) 2. 8a5999838e (grep: stess test PCRE v2 on invalid UTF-8 data, 2019-07-26) 3. c74b3cbb83 (t7812: add missing redirects, 2019-11-26) Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/helper')
0 files changed, 0 insertions, 0 deletions