diff options
author | Johannes Schindelin <johannes.schindelin@gmx.de> | 2019-03-14 11:25:04 (GMT) |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2019-03-18 02:44:14 (GMT) |
commit | 1a85b49b87af0e17a503b94df10d0b39472ad5b8 (patch) | |
tree | 134e30676e6d083164858ce3bb7d40b914509f27 /t/helper/test-parse-options.c | |
parent | 1dcda05820f1044a2ab35867c1fee1f829d2b92c (diff) | |
download | git-1a85b49b87af0e17a503b94df10d0b39472ad5b8.zip git-1a85b49b87af0e17a503b94df10d0b39472ad5b8.tar.gz git-1a85b49b87af0e17a503b94df10d0b39472ad5b8.tar.bz2 |
parse-options: make OPT_ARGUMENT() more useful
`OPT_ARGUMENT()` is intended to keep the specified long option in `argv`
and not to do anything else.
However, it would make a lot of sense for the caller to know whether
this option was seen at all or not. For example, we want to teach `git
difftool` to work outside of any Git worktree, but only when
`--no-index` was specified.
Note: nothing in Git uses OPT_ARGUMENT(). Even worse, looking through
the commit history, one can easily see that nothing even
ever used it, apart from the regression test.
So not only do we make `OPT_ARGUMENT()` more useful, we are also about
to introduce its first real user!
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/helper/test-parse-options.c')
-rw-r--r-- | t/helper/test-parse-options.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/helper/test-parse-options.c b/t/helper/test-parse-options.c index cc88fba..2232b2f 100644 --- a/t/helper/test-parse-options.c +++ b/t/helper/test-parse-options.c @@ -132,7 +132,7 @@ int cmd__parse_options(int argc, const char **argv) OPT_NOOP_NOARG(0, "obsolete"), OPT_STRING_LIST(0, "list", &list, "str", "add str to list"), OPT_GROUP("Magic arguments"), - OPT_ARGUMENT("quux", "means --quux"), + OPT_ARGUMENT("quux", NULL, "means --quux"), OPT_NUMBER_CALLBACK(&integer, "set integer to NUM", number_callback), { OPTION_COUNTUP, '+', NULL, &boolean, NULL, "same as -b", |