summaryrefslogtreecommitdiff
path: root/submodule.c
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2019-04-09 17:14:26 (GMT)
committerJunio C Hamano <gitster@pobox.com>2019-04-09 17:14:26 (GMT)
commit32414ceb854de44a9b4b74c975ae410713a17c99 (patch)
tree32b3a4956c97d6132fd0013bcd68d73fc68eb12b /submodule.c
parentc063a537bedd3b2363494171de2bbd58bf5c66a9 (diff)
parentbd5e567dc75abae58cb364d1e55cbaf67edb8c98 (diff)
downloadgit-32414ceb854de44a9b4b74c975ae410713a17c99.zip
git-32414ceb854de44a9b4b74c975ae410713a17c99.tar.gz
git-32414ceb854de44a9b4b74c975ae410713a17c99.tar.bz2
Merge branch 'jt/submodule-fetch-errmsg'
Error message update. * jt/submodule-fetch-errmsg: submodule: explain first attempt failure clearly
Diffstat (limited to 'submodule.c')
-rw-r--r--submodule.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/submodule.c b/submodule.c
index 21cf50c..b16c0ec 100644
--- a/submodule.c
+++ b/submodule.c
@@ -1548,6 +1548,13 @@ static int fetch_finish(int retvalue, struct strbuf *err,
struct oid_array *commits;
if (retvalue)
+ /*
+ * NEEDSWORK: This indicates that the overall fetch
+ * failed, even though there may be a subsequent fetch
+ * by commit hash that might work. It may be a good
+ * idea to not indicate failure in this case, and only
+ * indicate failure if the subsequent fetch fails.
+ */
spf->result = 1;
if (!task || !task->sub)