path: root/strbuf.h
diff options
authorJeff King <>2017-03-02 08:21:27 (GMT)
committerJunio C Hamano <>2017-03-02 19:05:04 (GMT)
commit311fc74826ac91cd6f6ea932460f88c475bbb310 (patch)
tree81a81dde991eafc37350a24589df1d6df9fbcadd /strbuf.h
parente322b60d65a14578995839caa5f48f5426236fdf (diff)
strbuf_branchname: drop return value
The return value from strbuf_branchname() is confusing and useless: it's 0 if the whole name was consumed by an @-mark, but otherwise is the length of the original name we fed. No callers actually look at the return value, so let's just get rid of it. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'strbuf.h')
1 files changed, 1 insertions, 1 deletions
diff --git a/strbuf.h b/strbuf.h
index 2262b12..3bcde39 100644
--- a/strbuf.h
+++ b/strbuf.h
@@ -562,7 +562,7 @@ static inline void strbuf_complete_line(struct strbuf *sb)
strbuf_complete(sb, '\n');
-extern int strbuf_branchname(struct strbuf *sb, const char *name);
+extern void strbuf_branchname(struct strbuf *sb, const char *name);
extern int strbuf_check_branch_ref(struct strbuf *sb, const char *name);
extern void strbuf_addstr_urlencode(struct strbuf *, const char *,