summaryrefslogtreecommitdiff
path: root/shallow.c
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2017-09-05 12:14:23 (GMT)
committerJunio C Hamano <gitster@pobox.com>2017-09-06 08:19:52 (GMT)
commitd88ef6605120fd75be38376ba147623cf427bf73 (patch)
tree921faad50f4f5757c10f8d0b6e6ff4359f659b94 /shallow.c
parentc0e963b77c6892d40d4ca81a71098aaa6c4eaed3 (diff)
downloadgit-d88ef6605120fd75be38376ba147623cf427bf73.zip
git-d88ef6605120fd75be38376ba147623cf427bf73.tar.gz
git-d88ef6605120fd75be38376ba147623cf427bf73.tar.bz2
verify_signed_buffer: prefer close_tempfile() to close()
We do a manual close() on the descriptor provided to us by mks_tempfile. But this runs contrary to the advice in tempfile.h, which notes that you should always use close_tempfile(). Otherwise the descriptor may be reused without the tempfile object knowing it, and the later call to delete_tempfile() could close a random descriptor. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'shallow.c')
0 files changed, 0 insertions, 0 deletions