path: root/sha1_name.c
diff options
authorJeff King <>2017-05-19 12:51:40 (GMT)
committerJunio C Hamano <>2017-05-24 01:59:27 (GMT)
commitd89797feff053bba939b62ee442f56e3fc98062b (patch)
tree209e7b9b1ac27d682f915fd6d0acab06f6b6637d /sha1_name.c
parentf632dedd8d29da20d546612d908a5c1b2ebf37aa (diff)
handle_revision_arg: hoist ".." check out of range parsing
Since 003c84f6d (specifying ranges: we did not mean to make ".." an empty set, 2011-05-02), we treat the argument ".." specially. We detect it by noticing that both sides of the range are empty, and that this is a non-symmetric two-dot range. While correct, this makes the code overly complicated. We can just detect ".." up front before we try to do further parsing. This avoids having to de-munge the NUL from dotdot, and lets us eliminate an extra const array (which we needed only to do direct pointer comparisons). It also removes the one code path from the range-parsing conditional that requires us to return -1. That will make it simpler to pull the dotdot parsing out into its own function. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'sha1_name.c')
0 files changed, 0 insertions, 0 deletions