path: root/setup.c
diff options
authorClemens Buchacher <>2011-09-04 10:41:59 (GMT)
committerJunio C Hamano <>2011-09-06 19:50:10 (GMT)
commit5879f5684cfe8a38326b4ffd078f96e35c68e640 (patch)
tree23b8f003c9692debdfbbc4b40f35d0c26920dddc /setup.c
parent8894d5358095a08c2f700a87ce9fdefb0b6eb61b (diff)
remove prefix argument from pathspec_prefix
Passing a prefix to a function that is supposed to find the prefix is strange. And it's really only used if the pathspec is NULL. Make the callers handle this case instead. As we are always returning a fresh copy of a string (or NULL), change the type of the returned value to non-const "char *". Signed-off-by: Clemens Buchacher <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'setup.c')
1 files changed, 2 insertions, 2 deletions
diff --git a/setup.c b/setup.c
index 699fcf0..f767d8a 100644
--- a/setup.c
+++ b/setup.c
@@ -264,13 +264,13 @@ const char **get_pathspec(const char *prefix, const char **pathspec)
return pathspec;
-const char *pathspec_prefix(const char *prefix, const char **pathspec)
+char *pathspec_prefix(const char **pathspec)
const char **p, *n, *prev;
unsigned long max;
if (!pathspec)
- return prefix ? xmemdupz(prefix, strlen(prefix)) : NULL;
+ return NULL;
prev = NULL;
max = PATH_MAX;