summaryrefslogtreecommitdiff
path: root/setup.c
diff options
context:
space:
mode:
authorGreg Brockman <gdb@MIT.EDU>2010-07-20 04:46:21 (GMT)
committerJunio C Hamano <gitster@pobox.com>2010-07-20 16:17:39 (GMT)
commit3c9d0414ed2db0167e6c828b547be8fc9f88fccc (patch)
tree7931e35acd4458bdfa34050aead1209af12dbb24 /setup.c
parentc173dad58787a7f11a526dbcdaa5a2fe9ff1c87f (diff)
downloadgit-3c9d0414ed2db0167e6c828b547be8fc9f88fccc.zip
git-3c9d0414ed2db0167e6c828b547be8fc9f88fccc.tar.gz
git-3c9d0414ed2db0167e6c828b547be8fc9f88fccc.tar.bz2
Check size of path buffer before writing into it
This prevents a buffer overrun that could otherwise be triggered by creating a file called '.git' with contents gitdir: (something really long) Signed-off-by: Greg Brockman <gdb@mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'setup.c')
-rw-r--r--setup.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/setup.c b/setup.c
index 0e4cfe6..3bb0461 100644
--- a/setup.c
+++ b/setup.c
@@ -170,6 +170,8 @@ static int is_git_directory(const char *suspect)
char path[PATH_MAX];
size_t len = strlen(suspect);
+ if (PATH_MAX <= len + strlen("/objects"))
+ die("Too long path: %.*s", 60, suspect);
strcpy(path, suspect);
if (getenv(DB_ENVIRONMENT)) {
if (access(getenv(DB_ENVIRONMENT), X_OK))