path: root/sequencer.c
diff options
authorJeff King <>2017-04-20 21:09:35 (GMT)
committerJunio C Hamano <>2017-04-21 04:04:34 (GMT)
commit16d2676c9ee996208277772fdf81dda212355440 (patch)
tree74af8cd55456aa59bcc75fe4bfa715583461bc48 /sequencer.c
parent8c2ca3a6d6d0bf51332f92d25b7902f9943aaaf2 (diff)
am: drop "dir" parameter from am_state_init
The only caller of this function passes in a static buffer returned from git_path(). This looks dangerous at first glance, but turns out to be OK because the first thing we do is xstrdup() the result. Let's turn this into a git_pathdup(). That's slightly more efficient (no extra copy), and makes it easier to audit for dangerous git_path() invocations. Since there's only a single caller, let's just set this default path inside the init function. That makes the memory ownership clear. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'sequencer.c')
0 files changed, 0 insertions, 0 deletions