summaryrefslogtreecommitdiff
path: root/send-pack.c
diff options
context:
space:
mode:
authorAndy Whitcroft <apw@shadowen.org>2007-01-02 14:12:09 (GMT)
committerJunio C Hamano <junkio@cox.net>2007-01-03 07:33:21 (GMT)
commit825cee7b285d9c733e9aec03cf4362e8029ee1c1 (patch)
tree1db420a161330e3ca5d7e7612bd049c2799ee3a3 /send-pack.c
parent44a167b007a20189200f4baf9ff4f24aa0f7571e (diff)
downloadgit-825cee7b285d9c733e9aec03cf4362e8029ee1c1.zip
git-825cee7b285d9c733e9aec03cf4362e8029ee1c1.tar.gz
git-825cee7b285d9c733e9aec03cf4362e8029ee1c1.tar.bz2
send pack check for failure to send revisions list
When passing the revisions list to pack-objects we do not check for errors nor short writes. Introduce a new write_in_full which will handle short writes and report errors to the caller. Use this to short cut the send on failure, allowing us to wait for and report the child in case the failure is its fault. Signed-off-by: Andy Whitcroft <apw@shadowen.org> Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'send-pack.c')
-rw-r--r--send-pack.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/send-pack.c b/send-pack.c
index eaa6efb..c195d08 100644
--- a/send-pack.c
+++ b/send-pack.c
@@ -65,12 +65,16 @@ static int pack_objects(int fd, struct ref *refs)
memcpy(buf + 1, sha1_to_hex(refs->old_sha1), 40);
buf[0] = '^';
buf[41] = '\n';
- write(pipe_fd[1], buf, 42);
+ if (!write_in_full(pipe_fd[1], buf, 42,
+ "send-pack: send refs"))
+ break;
}
if (!is_null_sha1(refs->new_sha1)) {
memcpy(buf, sha1_to_hex(refs->new_sha1), 40);
buf[40] = '\n';
- write(pipe_fd[1], buf, 41);
+ if (!write_in_full(pipe_fd[1], buf, 41,
+ "send-pack: send refs"))
+ break;
}
refs = refs->next;
}