summaryrefslogtreecommitdiff
path: root/run-command.h
diff options
context:
space:
mode:
authorShawn O. Pearce <spearce@spearce.org>2006-12-31 02:55:15 (GMT)
committerJunio C Hamano <junkio@cox.net>2006-12-31 06:22:14 (GMT)
commit9b0b50936ec76ad8e582d18d5bf54bc81c685e9b (patch)
tree1599e84bb2e53adbce3728f62d1c3c38d815a1e9 /run-command.h
parentad1a382fbb3ecb1bb017854a470816c815cc46c9 (diff)
downloadgit-9b0b50936ec76ad8e582d18d5bf54bc81c685e9b.zip
git-9b0b50936ec76ad8e582d18d5bf54bc81c685e9b.tar.gz
git-9b0b50936ec76ad8e582d18d5bf54bc81c685e9b.tar.bz2
Remove unnecessary argc parameter from run_command_v.
The argc parameter is never used by the run_command_v family of functions. Instead they require that the passed argv[] be NULL terminated so they can rely on the operating system's execvp function to correctly pass the arguments to the new process. Making the caller pass the argc is just confusing, as the caller could be mislead into believing that the argc might take precendece over the argv, or that the argv does not need to be NULL terminated. So goodbye argc. Don't come back. Signed-off-by: Shawn O. Pearce <spearce@spearce.org> Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'run-command.h')
-rw-r--r--run-command.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/run-command.h b/run-command.h
index 70b477a..82a0861 100644
--- a/run-command.h
+++ b/run-command.h
@@ -13,8 +13,8 @@ enum {
#define RUN_COMMAND_NO_STDIO 1
#define RUN_GIT_CMD 2 /*If this is to be git sub-command */
-int run_command_v_opt(int argc, const char **argv, int opt);
-int run_command_v(int argc, const char **argv);
+int run_command_v_opt(const char **argv, int opt);
+int run_command_v(const char **argv);
int run_command(const char *cmd, ...);
#endif