path: root/run-command.c
diff options
authorJunio C Hamano <>2010-01-09 07:05:41 (GMT)
committerJunio C Hamano <>2010-01-09 07:14:50 (GMT)
commit48ffef966c762578eb818c0c54a7e11dd054f5db (patch)
tree8288fd6e9577d4ab11d2f61b85bc4457cd1c2bdc /run-command.c
parent16e2cfa90993b23bda8ff1ffb958cac20e58b058 (diff)
ls-files: fix overeager pathspec optimization
Given pathspecs that share a common prefix, ls-files optimized its call into recursive directory reader by starting at the common prefix directory. If you have a directory "t" with an untracked file "t/junk" in it, but the top-level .gitignore file told us to ignore "t/", this resulted in: $ git ls-files -o --exclude-standard $ git ls-files -o --exclude-standard t/ t/junk $ git ls-files -o --exclude-standard t/junk t/junk $ cd t && git ls-files -o --exclude-standard junk We could argue that you are overriding the ignore file by giving a patchspec that matches or being in that directory, but it is somewhat unexpected. Worse yet, these behave differently: $ git ls-files -o --exclude-standard t/ . $ git ls-files -o --exclude-standard t/ t/junk This patch changes the optimization so that it notices when the common prefix directory that it starts reading from is an ignored one. Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'run-command.c')
0 files changed, 0 insertions, 0 deletions