summaryrefslogtreecommitdiff
path: root/revision.c
diff options
context:
space:
mode:
authorJulian Phillips <julian@quantumfyre.co.uk>2010-06-25 23:41:38 (GMT)
committerJunio C Hamano <gitster@pobox.com>2010-06-27 17:06:52 (GMT)
commit1d2f80fa79cdc6f7f4fa1cefb47d7d19be3bc5ee (patch)
treeddad96762347505bb9b455b2e891f74b0b320f99 /revision.c
parente8c8b7139c87c3e3017d3bff07f91c4349850d58 (diff)
downloadgit-1d2f80fa79cdc6f7f4fa1cefb47d7d19be3bc5ee.zip
git-1d2f80fa79cdc6f7f4fa1cefb47d7d19be3bc5ee.tar.gz
git-1d2f80fa79cdc6f7f4fa1cefb47d7d19be3bc5ee.tar.bz2
string_list: Fix argument order for string_list_append
Update the definition and callers of string_list_append to use the string_list as the first argument. This helps make the string_list API easier to use by being more consistent. Signed-off-by: Julian Phillips <julian@quantumfyre.co.uk> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'revision.c')
-rw-r--r--revision.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/revision.c b/revision.c
index f4b8b38..28f1c6d 100644
--- a/revision.c
+++ b/revision.c
@@ -1205,8 +1205,8 @@ static int handle_revision_opt(struct rev_info *revs, int argc, const char **arg
else
strbuf_addstr(&buf, "refs/notes/");
strbuf_addstr(&buf, arg+13);
- string_list_append(strbuf_detach(&buf, NULL),
- revs->notes_opt.extra_notes_refs);
+ string_list_append(revs->notes_opt.extra_notes_refs,
+ strbuf_detach(&buf, NULL));
} else if (!strcmp(arg, "--no-notes")) {
revs->show_notes = 0;
revs->show_notes_given = 1;