path: root/rev-list.c
diff options
authorLinus Torvalds <>2006-04-18 00:43:40 (GMT)
committerJunio C Hamano <>2006-04-18 04:44:33 (GMT)
commita4d34e2db5565e6b75f79f9d3938aa9151e72e44 (patch)
tree0e27f998dab2e89b5e8b4f63248d9e9925eacffa /rev-list.c
parenteab144ac49c18d981261c2d0ba964d6380d9f1da (diff)
Log message printout cleanups (#3): fix --pretty=oneline
This option is very special, since pretty_print_commit() will _remove_ the newline at the end of it, so we want to have an extra separator between the things. I added a honking big comment this time, so that (a) I don't forget this _again_ (I broke "oneline" several times during this printout cleanup), and so that people can understand _why_ the code does what it does. Now, arguably the alternate fix is to always have the '\n' at the end in pretty-print-commit, but git-rev-list depends on the current behaviour (but we could have git-rev-list remove it, whatever). With the big comment, the code hopefully doesn't get broken again. And now things like git log --pretty=oneline --cc --patch-with-stat works (even if that is admittedly a totally insane combination: if you want the patch, having the "oneline" log format is just crazy, but hey, it _works_. Even insane people are people). Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'rev-list.c')
0 files changed, 0 insertions, 0 deletions