path: root/rev-list.c
diff options
authorLinus Torvalds <>2005-10-26 15:18:13 (GMT)
committerJunio C Hamano <>2005-10-26 23:49:38 (GMT)
commit19a7e7151d0dfd22619daabbaa72a24715fae0ca (patch)
tree3ca68b1297caede2fa4d730b67135d617f02bdc5 /rev-list.c
parent7b34c2fae0d2875b35ad1cc0e416b9c2b9b02b1f (diff)
git-rev-list: do not forget non-commit refs
What happens is that the new logic decides that if it can't look up a commit reference (ie "get_commit_reference()" returns NULL), the thing must be a pathname. Fair enough. But wrong. The thing is, it may be a perfectly fine ref that _isn't_ a commit. In git, you have a tag that points to your PGP key, and in the kernel, I have a tag that points to a tree (and a direct ref that points to that tree too, for that matter). So the rule is (as for all the other programs that mix revs and pathnames) not that we only accept commit references, but _any_ valid object ref. If the object then isn't a commit ref, git-rev-list will either ignore it, or add it to the list of non-commit objects (if using "--objects"). The solution is to move the "get_sha1()" out of get_commit_reference(), and into the callers. In fact, we already _have_ the SHA1 in the case of the handle_all() loop, since for_each_ref() will have done it for us, so this is the correct thing to do anyway. This patch (on top of the original one) does exactly that. Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'rev-list.c')
1 files changed, 14 insertions, 12 deletions
diff --git a/rev-list.c b/rev-list.c
index ac7a47f..2b82b8a 100644
--- a/rev-list.c
+++ b/rev-list.c
@@ -613,13 +613,10 @@ static void add_pending_object(struct object *obj, const char *name)
add_object(obj, &pending_objects, name);
-static struct commit *get_commit_reference(const char *name, unsigned int flags)
+static struct commit *get_commit_reference(const char *name, const unsigned char *sha1, unsigned int flags)
- unsigned char sha1[20];
struct object *object;
- if (get_sha1(name, sha1))
- return NULL;
object = parse_object(sha1);
if (!object)
die("bad object %s", name);
@@ -697,7 +694,7 @@ static struct commit_list **global_lst;
static int include_one_commit(const char *path, const unsigned char *sha1)
- struct commit *com = get_commit_reference(path, 0);
+ struct commit *com = get_commit_reference(path, sha1, 0);
handle_one_commit(com, global_lst);
return 0;
@@ -720,6 +717,7 @@ int main(int argc, const char **argv)
const char *arg = argv[i];
char *dotdot;
struct commit *commit;
+ unsigned char sha1[20];
if (!strncmp(arg, "--max-count=", 12)) {
max_count = atoi(arg + 12);
@@ -808,15 +806,19 @@ int main(int argc, const char **argv)
flags = 0;
dotdot = strstr(arg, "..");
if (dotdot) {
+ unsigned char from_sha1[20];
char *next = dotdot + 2;
- struct commit *exclude = NULL;
- struct commit *include = NULL;
*dotdot = 0;
if (!*next)
next = "HEAD";
- exclude = get_commit_reference(arg, UNINTERESTING);
- include = get_commit_reference(next, 0);
- if (exclude && include) {
+ if (!get_sha1(arg, from_sha1) && !get_sha1(next, sha1)) {
+ struct commit *exclude;
+ struct commit *include;
+ exclude = get_commit_reference(arg, from_sha1, UNINTERESTING);
+ include = get_commit_reference(next, sha1, 0);
+ if (!exclude || !include)
+ die("Invalid revision range %s..%s", arg, next);
limited = 1;
handle_one_commit(exclude, &list);
handle_one_commit(include, &list);
@@ -829,9 +831,9 @@ int main(int argc, const char **argv)
limited = 1;
- commit = get_commit_reference(arg, flags);
- if (!commit)
+ if (get_sha1(arg, sha1) < 0)
+ commit = get_commit_reference(arg, sha1, flags);
handle_one_commit(commit, &list);