path: root/remote.h
diff options
authorJonas Fonseca <>2008-04-13 09:56:54 (GMT)
committerJunio C Hamano <>2008-04-18 23:31:27 (GMT)
commit24b6177e0261efba063c0b83ae0cdc5993945da9 (patch)
tree668917044c4bb47748f7a39339313591c8487bb0 /remote.h
parentd0ab520a2599afdfd4d61894863984fc36842b12 (diff)
git-remote: reject adding remotes with invalid names
This can happen if the arguments to git-remote add is switched by the user, and git would only show an error if fetching was also requested. Fix it by using the refspec parsing engine to check if the requested name can be parsed as a remote before add it. Also cleanup so that the "remote.<name>.url" config name buffer is only initialized once. Signed-off-by: Jonas Fonseca <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'remote.h')
1 files changed, 1 insertions, 0 deletions
diff --git a/remote.h b/remote.h
index 7e9ae79..a38774b 100644
--- a/remote.h
+++ b/remote.h
@@ -67,6 +67,7 @@ void free_refs(struct ref *ref);
void ref_remove_duplicates(struct ref *ref_map);
+int valid_fetch_refspec(const char *refspec);
struct refspec *parse_fetch_refspec(int nr_refspec, const char **refspec);
struct refspec *parse_push_refspec(int nr_refspec, const char **refspec);