summaryrefslogtreecommitdiff
path: root/refs
diff options
context:
space:
mode:
authorSZEDER Gábor <szeder.dev@gmail.com>2018-01-22 17:50:09 (GMT)
committerJunio C Hamano <gitster@pobox.com>2018-01-22 19:32:51 (GMT)
commitf919ffebed3c570bf3c2a5f36444527ea5df42de (patch)
tree3d89f307b743c893848413a72d32b36e9fd8ec17 /refs
parent8279ed033f703d4115bee620dccd32a9ec94d9aa (diff)
downloadgit-f919ffebed3c570bf3c2a5f36444527ea5df42de.zip
git-f919ffebed3c570bf3c2a5f36444527ea5df42de.tar.gz
git-f919ffebed3c570bf3c2a5f36444527ea5df42de.tar.bz2
Use MOVE_ARRAY
Use the helper macro MOVE_ARRAY to move arrays. This is shorter and safer, as it automatically infers the size of elements. Patch generated by Coccinelle and contrib/coccinelle/array.cocci in Travis CI's static analysis build job. Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'refs')
-rw-r--r--refs/ref-cache.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/refs/ref-cache.c b/refs/ref-cache.c
index 82c1cf9..e90bd3e 100644
--- a/refs/ref-cache.c
+++ b/refs/ref-cache.c
@@ -238,10 +238,8 @@ int remove_entry_from_dir(struct ref_dir *dir, const char *refname)
return -1;
entry = dir->entries[entry_index];
- memmove(&dir->entries[entry_index],
- &dir->entries[entry_index + 1],
- (dir->nr - entry_index - 1) * sizeof(*dir->entries)
- );
+ MOVE_ARRAY(&dir->entries[entry_index],
+ &dir->entries[entry_index + 1], dir->nr - entry_index - 1);
dir->nr--;
if (dir->sorted > entry_index)
dir->sorted--;