path: root/refs.h
diff options
authorThomas Gummerer <>2017-09-12 22:59:21 (GMT)
committerJunio C Hamano <>2017-09-14 05:46:05 (GMT)
commitc788c54cde5f7d52e4db9d4971545c3b2456ddcf (patch)
treedce248ec153dd36465a672a2ece28dfbdf3594dc /refs.h
parent94c9fd268d4287f6fbfef84793288479905a7e48 (diff)
refs: strip out not allowed flags from ref_transaction_update
Callers are only allowed to pass certain flags into ref_transaction_update, other flags are internal to it. To prevent mistakes from the callers, strip the internal only flags out before continuing. This was noticed because of a compiler warning gcc 7.1.1 issued about passing a NULL parameter as second parameter to memcpy (through hashcpy): In file included from refs.c:5:0: refs.c: In function ‘ref_transaction_verify’: cache.h:948:2: error: argument 2 null where non-null expected [-Werror=nonnull] memcpy(sha_dst, sha_src, GIT_SHA1_RAWSZ); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from git-compat-util.h:165:0, from cache.h:4, from refs.c:5: /usr/include/string.h:43:14: note: in a call to function ‘memcpy’ declared here extern void *memcpy (void *__restrict __dest, const void *__restrict __src, ^~~~~~ The call to hascpy in ref_transaction_add_update is protected by the passed in flags, but as we only add flags there, gcc notices REF_HAVE_NEW or REF_HAVE_OLD flags could be passed in from the outside, which would potentially result in passing in NULL as second parameter to memcpy. Fix both the compiler warning, and make the interface safer for its users by stripping the internal flags out. Suggested-by: Michael Haggerty <> Signed-off-by: Thomas Gummerer <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'refs.h')
1 files changed, 8 insertions, 0 deletions
diff --git a/refs.h b/refs.h
index 6daa78e..4d75c20 100644
--- a/refs.h
+++ b/refs.h
@@ -355,6 +355,14 @@ int refs_pack_refs(struct ref_store *refs, unsigned int flags);
+ * Flags that can be passed in to ref_transaction_update
+ */
* Setup reflog before using. Fill in err and return -1 on failure.
int refs_create_reflog(struct ref_store *refs, const char *refname,