path: root/refs.c
diff options
authorBrandon Casey <>2011-10-08 03:20:21 (GMT)
committerJunio C Hamano <>2011-10-10 17:05:22 (GMT)
commit687296960d774a45df31df7bc371d01106a6f6b7 (patch)
tree75eb24bf9d3bf622cb72c8c23e4528a21178fc70 /refs.c
parent43d20a8c50355f7f68548e91bd8822c3cbfff52f (diff)
refs.c: abort ref search if ref array is empty
The bsearch() implementation on IRIX 6.5 segfaults if it is passed NULL for the base array argument even if number-of-elements is zero. So, let's work around it by detecting an empty array and aborting early. This is a useful optimization in its own right anyway, since we avoid a useless allocation and initialization of the ref_entry when the ref array is empty. Signed-off-by: Brandon Casey <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'refs.c')
1 files changed, 3 insertions, 0 deletions
diff --git a/refs.c b/refs.c
index c31b461..cbc4c5d 100644
--- a/refs.c
+++ b/refs.c
@@ -110,6 +110,9 @@ static struct ref_entry *search_ref_array(struct ref_array *array, const char *n
if (name == NULL)
return NULL;
+ if (!array->nr)
+ return NULL;
len = strlen(name) + 1;
e = xmalloc(sizeof(struct ref_entry) + len);
memcpy(e->name, name, len);