diff options
author | Jeff King <peff@peff.net> | 2023-07-10 21:12:13 (GMT) |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2023-07-10 21:48:55 (GMT) |
commit | b571fb98008b485bfc6f7d6538b79a7e92d731f4 (patch) | |
tree | 2837a8b21d55850720fab7e3a5dd42f53777e329 /ref-filter.c | |
parent | 311bfe18ce8563d0b1b571e9dc9eb35b97de3790 (diff) | |
download | git-b571fb98008b485bfc6f7d6538b79a7e92d731f4.zip git-b571fb98008b485bfc6f7d6538b79a7e92d731f4.tar.gz git-b571fb98008b485bfc6f7d6538b79a7e92d731f4.tar.bz2 |
ref-filter: add `ref_filter_clear()`
We did not bother to clean up at all in `git branch` or `git tag`, and
`git for-each-ref` only cleans up a couple of members.
Add and call `ref_filter_clear()` when cleaning up a `struct
ref_filter`. Running this patch (without any test changes) indicates a
couple of now leak-free tests. This was found by running:
$ make SANITIZE=leak
$ make -C t GIT_TEST_PASSING_SANITIZE_LEAK=check GIT_TEST_OPTS=--immediate
(Note that the `reachable_from` and `unreachable_from` lists should be
cleaned as they are used. So this is just covering any case where we
might bail before running the reachability check.)
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'ref-filter.c')
-rw-r--r-- | ref-filter.c | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/ref-filter.c b/ref-filter.c index 048d277..d32f426 100644 --- a/ref-filter.c +++ b/ref-filter.c @@ -2866,3 +2866,19 @@ int parse_opt_merge_filter(const struct option *opt, const char *arg, int unset) return 0; } + +void ref_filter_init(struct ref_filter *filter) +{ + struct ref_filter blank = REF_FILTER_INIT; + memcpy(filter, &blank, sizeof(blank)); +} + +void ref_filter_clear(struct ref_filter *filter) +{ + oid_array_clear(&filter->points_at); + free_commit_list(filter->with_commit); + free_commit_list(filter->no_commit); + free_commit_list(filter->reachable_from); + free_commit_list(filter->unreachable_from); + ref_filter_init(filter); +} |