diff options
| author | Victoria Dye <vdye@github.com> | 2024-02-08 01:57:19 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2024-02-08 05:33:37 (GMT) |
| commit | 46176d77c9e0b219a78d64cb99d8dbf4d9bcde2d (patch) | |
| tree | 92e90882f3a31f6104345813c3ed18ba3cbfc713 /ref-filter.c | |
| parent | 235986be822c9f8689be2e9a0b7804d0b1b6d821 (diff) | |
| download | git-46176d77c9e0b219a78d64cb99d8dbf4d9bcde2d.zip git-46176d77c9e0b219a78d64cb99d8dbf4d9bcde2d.tar.gz git-46176d77c9e0b219a78d64cb99d8dbf4d9bcde2d.tar.bz2 | |
ref-filter.c: sort formatted dates by byte value
Update the ref sorting functions of 'ref-filter.c' so that when date fields
are specified with a format string (such as in 'git for-each-ref
--sort=creatordate:<something>'), they are sorted by their formatted string
value rather than by the underlying numeric timestamp. Currently, date
fields are always sorted by timestamp, regardless of whether formatting
information is included in the '--sort' key.
Leaving the default (unformatted) date sorting unchanged, sorting by the
formatted date string adds some flexibility to 'for-each-ref' by allowing
for behavior like "sort by year, then by refname within each year" or "sort
by time of day". Because the inclusion of a format string previously had no
effect on sort behavior, this change likely will not affect existing usage
of 'for-each-ref' or other ref listing commands.
Additionally, update documentation & tests to document the new sorting
mechanism.
Signed-off-by: Victoria Dye <vdye@github.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'ref-filter.c')
| -rw-r--r-- | ref-filter.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/ref-filter.c b/ref-filter.c index 35b989e..be14b56 100644 --- a/ref-filter.c +++ b/ref-filter.c @@ -1611,6 +1611,12 @@ static void grab_date(const char *buf, struct atom_value *v, const char *atomnam if (formatp) { formatp++; parse_date_format(formatp, &date_mode); + + /* + * If this is a sort field and a format was specified, we'll + * want to compare formatted date by string value. + */ + v->atom->type = FIELD_STR; } if (!eoemail) |