path: root/receive-pack.c
diff options
authorShawn O. Pearce <>2006-12-31 02:55:15 (GMT)
committerJunio C Hamano <>2006-12-31 06:22:14 (GMT)
commit9b0b50936ec76ad8e582d18d5bf54bc81c685e9b (patch)
tree1599e84bb2e53adbce3728f62d1c3c38d815a1e9 /receive-pack.c
parentad1a382fbb3ecb1bb017854a470816c815cc46c9 (diff)
Remove unnecessary argc parameter from run_command_v.
The argc parameter is never used by the run_command_v family of functions. Instead they require that the passed argv[] be NULL terminated so they can rely on the operating system's execvp function to correctly pass the arguments to the new process. Making the caller pass the argc is just confusing, as the caller could be mislead into believing that the argc might take precendece over the argv, or that the argv does not need to be NULL terminated. So goodbye argc. Don't come back. Signed-off-by: Shawn O. Pearce <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'receive-pack.c')
1 files changed, 2 insertions, 2 deletions
diff --git a/receive-pack.c b/receive-pack.c
index 59b682c..2b0ba63 100644
--- a/receive-pack.c
+++ b/receive-pack.c
@@ -187,7 +187,7 @@ static void run_update_post_hook(struct command *cmd)
argv[argc] = NULL;
- run_command_v_opt(argc, argv, RUN_COMMAND_NO_STDIO);
+ run_command_v_opt(argv, RUN_COMMAND_NO_STDIO);
@@ -283,7 +283,7 @@ static const char *unpack(void)
unpacker[0] = "unpack-objects";
unpacker[1] = hdr_arg;
unpacker[2] = NULL;
- code = run_command_v_opt(1, unpacker, RUN_GIT_CMD);
+ code = run_command_v_opt(unpacker, RUN_GIT_CMD);
switch (code) {
case 0:
return NULL;