diff options
| author | Elijah Newren <newren@gmail.com> | 2020-11-02 18:55:05 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2020-11-02 20:15:50 (GMT) |
| commit | 6da1a258142ac2422c8c57c54b92eaed3c86226e (patch) | |
| tree | 480a35cb1c8754d02f21233d2efd8e5d28ff24d0 /range-diff.c | |
| parent | 33f20d82177871225e17d9dd44169a52a36c9f1d (diff) | |
| download | git-6da1a258142ac2422c8c57c54b92eaed3c86226e.zip git-6da1a258142ac2422c8c57c54b92eaed3c86226e.tar.gz git-6da1a258142ac2422c8c57c54b92eaed3c86226e.tar.bz2 | |
hashmap: provide deallocation function names
hashmap_free(), hashmap_free_entries(), and hashmap_free_() have existed
for a while, but aren't necessarily the clearest names, especially with
hashmap_partial_clear() being added to the mix and lazy-initialization
now being supported. Peff suggested we adopt the following names[1]:
- hashmap_clear() - remove all entries and de-allocate any
hashmap-specific data, but be ready for reuse
- hashmap_clear_and_free() - ditto, but free the entries themselves
- hashmap_partial_clear() - remove all entries but don't deallocate
table
- hashmap_partial_clear_and_free() - ditto, but free the entries
This patch provides the new names and converts all existing callers over
to the new naming scheme.
[1] https://lore.kernel.org/git/20201030125059.GA3277724@coredump.intra.peff.net/
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'range-diff.c')
| -rw-r--r-- | range-diff.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/range-diff.c b/range-diff.c index 24dc435..befeeca 100644 --- a/range-diff.c +++ b/range-diff.c @@ -266,7 +266,7 @@ static void find_exact_matches(struct string_list *a, struct string_list *b) } } - hashmap_free(&map); + hashmap_clear(&map); } static void diffsize_consume(void *data, char *line, unsigned long len) |